Python bindings: turn on exceptions by default (refs OSGeo#7452)

rouault · Mar 18, 2023 · 3b8eb4f · 3b8eb4f
1 parent e90d65e
commit 3b8eb4f
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 22 deletions.
diff --git a/swig/include/gdal_array.i b/swig/include/gdal_array.i
@@ -66,27 +66,6 @@ typedef int GDALRIOResampleAlg;
 
 %include "python_strings.i"
 
-%{
-#include "cpl_conv.h"
-%}
-
-%inline %{
-// Note: copied&pasted from python_exceptions.i
-static void _StoreLastException()
-{
-    const char* pszLastErrorMessage =
-        CPLGetThreadLocalConfigOption("__last_error_message", NULL);
-    const char* pszLastErrorCode =
-        CPLGetThreadLocalConfigOption("__last_error_code", NULL);
-    if( pszLastErrorMessage != NULL && pszLastErrorCode != NULL )
-    {
-        CPLErrorSetState( CE_Failure,
-            static_cast<CPLErrorNum>(atoi(pszLastErrorCode)),
-            pszLastErrorMessage);
-    }
-}
-%}
-
 %{
 #include <vector>
 #include "gdal_priv.h"
@@ -2087,7 +2066,6 @@ def GDALTypeCodeToNumericTypeCode(gdal_code):
 
 def _RaiseException():
     if gdal.GetUseExceptions():
-        _StoreLastException()
         raise RuntimeError(gdal.GetLastErrorMsg())
 
 def LoadFile(filename, xoff=0, yoff=0, xsize=None, ysize=None,

diff --git a/swig/include/python/gdal_python.i b/swig/include/python/gdal_python.i
@@ -12,6 +12,7 @@
   if ( GDALGetDriverCount() == 0 ) {
     GDALAllRegister();
   }
+  UseExceptions();
 %}
 
 %{

diff --git a/swig/include/python/gnm_python.i b/swig/include/python/gnm_python.i
@@ -12,6 +12,7 @@
   if ( OGRGetDriverCount() == 0 ) {
     OGRRegisterAll();
   }
+  UseExceptions();
 
 %}
 #endif

diff --git a/swig/include/python/ogr_python.i b/swig/include/python/ogr_python.i
@@ -12,6 +12,7 @@
   if ( OGRGetDriverCount() == 0 ) {
     OGRRegisterAll();
   }
+  UseExceptions();
 
 %}
 #endif

diff --git a/swig/include/python/osr_python.i b/swig/include/python/osr_python.i
@@ -6,6 +6,10 @@
 
 %feature("autodoc");
 
+%init %{
+  UseExceptions();
+%}
+
 #ifndef FROM_GDAL_I
 %{
 #define MODULE_NAME           "osr"
-Original file line number
+Diff line change
@@ Expand Up / @@ -12,6 +12,7 @@ @@
       if ( GDALGetDriverCount() == 0 ) {
         GDALAllRegister();
       }
+      UseExceptions();
     %}
     %{
@@ Expand Down @@