Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP multiple use statements combined not highlighted properly #1353

Closed
HypeMC opened this issue Nov 3, 2019 · 1 comment · Fixed by #1489
Closed

PHP multiple use statements combined not highlighted properly #1353

HypeMC opened this issue Nov 3, 2019 · 1 comment · Fixed by #1489
Assignees
@pyrmont
Labels
bugfix-request A request for a bugfix to be developed.

Comments

@HypeMC
Copy link

HypeMC commented Nov 3, 2019

Name of the lexer
PHP

Code sample

use Class1, Class2, Class3;

Screenshots
image
@HypeMC HypeMC added the bugfix-request A request for a bugfix to be developed. label Nov 3, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Nov 3, 2019

@HypeMC Thanks for the report! This sounds pretty straightforward to fix. I'll have a look at the PHP lexer and see what's breaking :)

@pyrmont pyrmont self-assigned this Jan 18, 2020
julp added a commit to julp/rouge that referenced this issue Apr 6, 2020
@julp
fix incomplete handling of use statements (relative to namespaces):
826b516 
* (sub)keywords `function` and `const` were tokenized as Name.Namespace
* enumerated names in non-grouped `use` were improperly highlighted
(eg `use Foo, Bar;`, anything after the first name to the final `;`
or `{` was tokenized as Error)
* a namespaced name triggered Error on `\\` in grouped `use` statement
(eg `use some\name\{const Foo\BAR};`)

And add support to comments in this `use` statement.

Also fixes:
* rouge-ruby#1353
* rouge-ruby#1361
@pyrmont pyrmont mentioned this issue Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pyrmont pyrmont

Labels
bugfix-request A request for a bugfix to be developed.
Projects
None yet
Milestone
No milestone
2 participants
@pyrmont @HypeMC