Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim Lexer: Fix multiline ruby code #1094

Closed
wants to merge 0 commits into from
Closed

Slim Lexer: Fix multiline ruby code #1094

wants to merge 0 commits into from

Conversation

reneklacan
Copy link
Contributor

@reneklacan reneklacan commented Feb 26, 2019

This change fixes lexing of multiline string using \ at the end of the line.

Example:

= render( \
    partial: 'foo',
    locals: { \
      foo: :bar,
    },
  )

@reneklacan
Copy link
Contributor Author

Looks like Travis CI failure is not related to my change.

@pyrmont
Copy link
Contributor

pyrmont commented May 27, 2019

@reneklacan Would you be able to add an example to the visual sample for Slim? That'll kick off a new build on Travis now that we've got that fixed.

@reneklacan
Copy link
Contributor Author

Hi @pyrmont, thank you for merging my commit.

Would you be able to add an example to the visual sample for Slim?

Sorry, I'm not quite sure what do you mean by the visual sample for Slim? Can you point me to a specific file? I looked around for samples but didn't find anything.

@reneklacan reneklacan closed this May 28, 2019
@reneklacan
Copy link
Contributor Author

I messed up a little bit while rebasing which automatically closed this PR so I opened a new one #1130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants