Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lexer for Windows Batch files support #1286

Merged
merged 17 commits into from
Aug 2, 2019
Merged

Add lexer for Windows Batch files support #1286

merged 17 commits into from
Aug 2, 2019

Conversation

carlos-montiers
Copy link
Contributor

@carlos-montiers carlos-montiers commented Jul 28, 2019 •
edited by pyrmont
Loading

Add lexer for support Windows Batch files. This fixes #252.

@carlos-montiers carlos-montiers changed the title Windows Batch files support #252 Add lexer for support Windows Batch files. #252 Jul 28, 2019
@carlos-montiers carlos-montiers changed the title Add lexer for support Windows Batch files. #252 Add lexer for Windows Batch files support. #252 Jul 28, 2019
@carlos-montiers carlos-montiers changed the title Add lexer for Windows Batch files support. #252 Add lexer for Windows Batch files support Jul 28, 2019
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jul 29, 2019
pyrmont
pyrmont suggested changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing such a long-standing issue! Let me know if any of the comments are unclear :)

@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed needs-review The PR needs to be reviewed and removed needs-review The PR needs to be reviewed author-action The PR has been reviewed but action by the author is needed labels Jul 29, 2019
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Jul 30, 2019
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Aug 2, 2019
@pyrmont pyrmont merged commit 5eaf516 into rouge-ruby:master Aug 2, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Aug 2, 2019

@carlos-montiers Thanks for the submission of this lexer. Great to close an issue that's been open for more than four years! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrmont pyrmont pyrmont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows Batch files support
2 participants
@carlos-montiers @pyrmont