GHC Cmm

[supersven]

This is a lexer for C minus minus, which is a dialect of C--. It's used as intermediate and hand-written language in the Glasgow Haskell Compiler.

More details:

• https://en.wikipedia.org/wiki/C--
• https://gitlab.haskell.org/ghc/ghc/wikis/commentary/rts/cmm

[pyrmont]

Sorry it's taken so long to get to this :( I hope you haven't lost interest!

It's very cleanly defined but it does feel a little like a proper language parser rather than a syntax highlighter. Would it not be possible to have a simpler number of rules that match keywords individually rather than looking to match sets of keywords with arbitrary whitespace and comments between them?

[supersven]

Hey @pyrmont ,
No worries, I saw that you were very busy with many PRs...

Thanks a lot for taking the time for this review!

I will check, if I can simplify the keyword matching rules. (I first have to remember what I actually did ... 😉 )

[pyrmont]

@supersven This looks good to me. Did you have anything else you wanted to add?

[supersven]

@pyrmont I'm doing some final testing ...

I've pushed a small change regarding CLOSURE.

[pyrmont]

@supersven No worries, just say when! :)

[supersven]

@pyrmont ,

I've finished testing: I think it can now be merged. 😃

Thanks a lot for your time and this review!

(Please squash the commits during merge.)

[pyrmont]

Sorry for not raising this before (especially after I said this was good to go) but I just noticed this:

[pyrmont]

@supersven Thanks for all the work you put into this. The lexer will be part of the next version of Rouge, v3.18.0. That version is scheduled for release on Tuesday 14 April (so either today or tomorrow depending on where you're reading this!).