Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slice interface language support #867

Merged
merged 9 commits into from
Nov 20, 2019
Merged

Slice interface language support #867

merged 9 commits into from
Nov 20, 2019

Conversation

jolkdarr
Copy link
Contributor

@jolkdarr jolkdarr commented Jan 27, 2018 •
edited
Loading

vidarh
vidarh suggested changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@vidarh vidarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your submission. I'm trying to help triage pull requests so we can try to get the backlog down. Just one minor nit (which I'm guessing is due to the age of the pull request...). :)

@vidarh vidarh mentioned this pull request Jan 13, 2019
Closed
@pyrmont pyrmont mentioned this pull request May 13, 2019
Merged
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Aug 16, 2019
@pyrmont pyrmont self-assigned this Aug 26, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Aug 30, 2019

@jolkdarr I'm sorry it's taken such a long time to get this. Apologies also for force pushing to your branch. It's been such a long time since you made the original PR that it seemed unfair to ask you to make a couple of minor requests.

Please let me know if anything looks off or if you had any questions. Hopefully we'll be able to get this merged in soon!

@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Aug 30, 2019
@jolkdarr
Copy link
Contributor Author

Thanks @pyrmont for processing the PR.

@pyrmont
Copy link
Contributor

pyrmont commented Nov 18, 2019

@jolkdarr Does it look all right to you? Let me know and if it's OK, I'll merge it in.

@jolkdarr
Copy link
Contributor Author

OK for merging.
Thank you once again.

@pyrmont pyrmont merged commit 184848a into rouge-ruby:master Nov 20, 2019
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidarh vidarh vidarh requested changes

Assignees

@pyrmont pyrmont

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jolkdarr @pyrmont @vidarh