Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add powershell builtins #967

Closed

Conversation

miparnisari
Copy link
Contributor

@miparnisari miparnisari commented Aug 1, 2018

Fixes #966

How it looks (august 11)
image

@dblessing
Copy link
Collaborator

Thanks @miparnisari

Something doesn't seem quite right here. When I run the sample the latter part doesn't seem to be getting highlighted correctly?

screen shot 2018-08-02 at 9 34 59 am

@markroloff
Copy link

On line 621, looks like the foreach keyword was removed. You'll want to keep that in there as it's both an alias and a built-in.

@miparnisari
Copy link
Contributor Author

@dblessing that's because builtins are colored white :)

@markroloff oh, then I should make the regexes case sensitive because otherwise the lexer won't distinguish between foreach and ForEach.

@miparnisari miparnisari force-pushed the powershell-builtins branch from 9abf2cd to 594fffb Compare August 3, 2018 04:31
@dblessing
Copy link
Collaborator

@miparnisari Interesting. It doesn't look great from a highlighting perspective, but that's something we can/should address in another issue/PR.

Looks like some things changed, though. See this side-by-side comparison of before (left) and after (right). Most notably, try and catch are highlighted differently but also less apparent are several other things.

screen shot 2018-08-06 at 2 41 55 pm

@dblessing dblessing added the author-action The PR has been reviewed but action by the author is needed label Aug 6, 2018
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PowerShell lexer is missing ForEach-Object built-in cmdlet
4 participants