Simplify handlers (internal only) #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rougeth
force-pushed
the
simplify-handlers
branch
from
df5eb88 to
ecf2364
Compare
leportella
approved these changes
May 1, 2018
docs/handlers.rst
Outdated
| @@ -19,22 +19,23 @@ If the bot receives a message that is exactly equal to `ping` the response will | |||
|
|
|||
| Bottery has the following handlers available: | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Two lines between sections. I changed it a bit, is it better?
docs/handlers.rst
Outdated
| Create a new handler | ||
| -------------------- | ||
|
|
||
| The interface of a handler is quite simple. To create a new one, everything needed is a class with a method called ``match`` and an attribute called ``view``. The method ``match`` define if that handler should be used or not to respond to the new message. It must receive a ``Message`` as a parameter and return a boolean. The attribute ``view`` will be used if the ``match`` returns ``True``. |
There was a problem hiding this comment.
I think it is better to use "the handler's structure" instead of interface
docs/handlers.rst
Outdated
|
|
||
| .. code-block:: python | ||
|
|
||
| class LongTextHandler: |
There was a problem hiding this comment.
I think i would be clearer if the example had a pattern to compare, like StartsWithHandler or something similar. I got confused if this did the same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request make easier to create or extend handlers. Now Bottery choose the view to respond a new message according to a list of handler instances.
Closes: #161