Presence of badges messes up unselection of tabs

[henhal]

I have three tabs. Before using badges, selection and unselection works just fine.
After adding badges (but even without showing them), unselection does not work.

For example, if initially tab 0 is selected and I click on tab 2, tab 2 becomes visually selected and tab 0 is visually unselected. But if I then click tab 0 again, both tabs 0 and 2 stay visually selected. In this case I have debugged it enough to see that what happens is an unselect(0) followed by a select(0) instead of unselect(2) followed by select(0).

Since the presence of badges apparently mean you are adding one more container layout, I suppose the tags used for tracking active and inactive tabs doesn't work.

I am using 1.3.3.

[henhal]

The problem is that when badges are added, the newly created FrameLayout inherits the current tag from the LinearLayout carrying the pre-badge-tab, but the tag is not cleared on the LinearLayout.
So after the first selection of tab 2, the FrameLayouts will have tags INACTIVE, INACTIVE, ACTIVE as expected, but the embedded LinearLayouts will remain at ACTIVE, INACTIVE, INACTIVE.

Then when the user selects tab 0 again, BottomBar.findViewWithTag(ACTIVE) will erroneously find the obsolete LinearLayout inside tab 0 instead of the expected FrameLayout at position 2, and proceed to unselect the LinearLayout of tab 0 and select the FrameLayout of tab 0. After this we effectively have two selected tabs.

One solution would be to reset the tag of all LinearLayouts when converting tabs to badge-tabs (BottomBarBadge constructor):

    ViewGroup parent = (ViewGroup) tabToAddTo.getParent();
    parent.removeView(tabToAddTo);

    container.setTag(tabToAddTo.getTag());
    tabToAddTo.setTag(null); // <- this
    container.addView(tabToAddTo);
    container.addView(this);

To be honest, I think a cleaner solution would be to always use the FrameLayouts, it seems unnecessarily complex to convert the views in runtime just to make room for a badge inside the same container. One extra ViewGroup level around each tab even when they don't have badges likely won't impact performance?

As a temporary ugly workaround in my application code I managed to solve the problem like this:

BottomBarBadge badge = mBottomBar.makeBadgeForTabAt(pos, color, count);
((ViewGroup)badge.getParent()).getChildAt(0).setTag(null); // Remove tag of LinearLayout