Only apply new layout params if they have actually changed. #289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise will trigger an infinite loop of layout re-drawing if a badge is present which a) is bad for performance and b) breaks interactions with other custom behaviors
You can see this by overriding requestLayout in BottomBar.java:
You will observe this breakpoint is hit continually in the event that a badge is drawn on one of the tabs.
This took me about 3 hrs to debug and I would suggest is a Very Serious regression. Thanks!