Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply new layout params if they have actually changed. #289

Merged
merged 1 commit into from
Jun 13, 2016

Conversation

esilverberg
Copy link

Otherwise will trigger an infinite loop of layout re-drawing if a badge is present which a) is bad for performance and b) breaks interactions with other custom behaviors

You can see this by overriding requestLayout in BottomBar.java:

@Override
public void requestLayout() {
   super.requestLayout();
}

You will observe this breakpoint is hit continually in the event that a badge is drawn on one of the tabs.

This took me about 3 hrs to debug and I would suggest is a Very Serious regression. Thanks!

Otherwise will trigger an infinite loop of layout re-drawing if a badge is present which a) is bad for performance and b) breaks interactions with other behaviors
@esilverberg
Copy link
Author

FYI I believe this issue may also be mitigated by commit f41aac0

@roughike roughike merged commit 26dadef into roughike:master Jun 13, 2016
@esilverberg esilverberg deleted the layoutfix branch October 13, 2016 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants