Fixed views not being removed from the item container. #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 7, 2016 16:19
Removing views works like a cascade delete. If you have 3 views to remove, you remove position 0, then position 2, when you get to position 3, you only have one child at 0. This child will not be deleted. You can remove by index in decreasing order or just remove at index 0.
|
Maybe I'm missing something, but why can't removeAllViews() be used instead of iterating over each child one by one? |
|
@ygnessin You are right removeAllViews() is probably the better approach. I did not want to change very much code, because I'm not very familiar with the project, that's why I did not use that. |
|
@NegreaVlad |
added 2 commits
July 19, 2016 15:09
|
@roughike |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to remove all children you have to remove child at index 0 or
have indexes go in a decreasing order.
After removing child 0, all children go an index down.
If you have 3 views to remove, you remove position 0, then position 2,
when you get to position 3, this child will not be deleted, because
there no longer is a child at index 3. The only child is at position 0.
I was having trouble changing my BottomBarTabs. A view was not removed because of this.