Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in keyboard shortcut to activate buttons #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chookity-pokk
Copy link
Contributor

This is some of the first actual elisp I've ever really written, so it might not be great. Though I did test this on my setup and made some buttons and was able to activate them using the keybinding I put in there. Which by default is unbound to anything. I also think I set it up in a way to make it so the user can edit the keybinding in their config.

@rougier
Copy link
Owner

rougier commented Jan 9, 2024

Looks pretty good actually. Is there a specific reason for the C-c C-s binding (instead of return or space for example) ?
Also, there are some conflicts, you might need to rebase. And most importantly, since svg-lib is on ELPA, you'll need to sign the Copyright Assignment

@chookity-pokk
Copy link
Contributor Author

I can take care of the rebase after work today. I wasn't sure how to bind it to return while also still having return function normally, if that makes sense. If you know how then I will try implementing it!

I have signed a copyright assignment for the hyperbole project, so would I need to do it again for this project or does it apply to all contributions in general?

@chookity-pokk
Copy link
Contributor Author

@rougier Just an update here, I did a rebase and sent off for a copyright assignment. I haven't quite found a way to do the keyboard shortcut for enter/return without it overriding the whole buffer though.

@rougier
Copy link
Owner

rougier commented Feb 19, 2024

We could get inspiration from Emacs widget library and specifically the variable widget-keymap that is applied to widgets.

@chookity-pokk
Copy link
Contributor Author

I am currently dealing with a lot in my personal life so this likely won't be happening any time soon. If anyone wants to take this over, please feel free to. I will get to it when I have a chance but that likely won't be any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants