Invalid step in the installer for the root installer path. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2012 13:11
…taller if no _setp query is given.
| @@ -90,7 +90,7 @@ | |||
| } | |||
|
|
|||
| // go to 'check env' step if we have a local configuration | |||
| if ($RCI->configured && empty($_REQUEST['_step'])) { | |||
| if (!$RCI->configured && empty($_REQUEST['_step'])) { | |||
There was a problem hiding this comment.
Hmm, the comment says "if we have a local configuration". But since we don't have a step 0 (anymore) I guess the if ($RCI->configured) can be removed entirely. Checking for if (empty($_REQUEST['_step'])) should do the job here.
There was a problem hiding this comment.
I had the problem that I've got "Invalid step" when I opened the installer without a step. After negating the configured check the installer worked correct. But now (after the installation with a valid config and $rcmail_config['enable_installer'] = true;) I've got the "Invalid step" message again.
So I would recommend that you deny these pull request and I will try to solve these issue again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed wrong if statement for redirecting to the first step of the installer if no _setp query is given.