Add httpapi password change driver to connect to generic HTTP/HTTPS APIs #7439
Conversation
| * @param string $curpass Current password | ||
| * @param string $newpass New password | ||
| * @param string $username Login username | ||
| * @returns int PASSWORD_SUCCESS|PASSWORD_ERROR|PASSWORD_CONNECT_ERROR |
|
|
||
| $curl = curl_init(); | ||
|
|
||
| curl_setopt($curl, CURLOPT_CONNECTTIMEOUT , 5); |
| if ($ssl_verify) { | ||
| curl_setopt($curl, CURLOPT_SSL_VERIFYHOST , 2); | ||
| curl_setopt($curl, CURLOPT_SSL_VERIFYPEER , true); | ||
| } else { |
| } | ||
| } else { | ||
| rcube::raise_error(array( | ||
| 'code' => 600, |
There was a problem hiding this comment.
Again, not our style. It should be +8 spaces from the rcube:: above.
| return PASSWORD_CONNECT_ERROR; | ||
| } | ||
|
|
||
| curl_setopt($curl, CURLOPT_URL , $url); |
| @@ -49,6 +49,7 @@ | |||
| 2.1.21. Kpasswd | |||
| 2.1.22. Modoboa | |||
| 2.1.23. LDAP - Password Modify Extended Operation (ldap_exop) | |||
| 2.1.24. HTTP-API | |||
There was a problem hiding this comment.
The driver name is httpapi so add (httpapi) in the section title.
|
Hi, thanks for these tips. The coding style is not mine, I tried to follow the style of the plesk driver I used as a template, but now realise that file wasn't actually in your own code style. I will correct these. The reason for writing this was to write password changes to a simple API on our backend, but I decided to do it in a generic manner so it might be useful to other service providers, rather than requiring many similar or custom drivers. The (simple) API on our end just verifies the host is the webmail server, and as it already checks that the user's current password is correct, this was thought sufficient in terms of authentication. I will add in the ability to set custom headers and custom GET/POST variables (which could then be used for further authentication/API keys) in the hope that it is more universally useful. |
|
Thank you for submitting a Pull Request (PR) to the Roundcube GitHub project. You are receiving this message because your PR has conflicts which need to be resolved. We are trying to catch up on our backlog of old PRs and get them merged in (where appropriate). Therefor, we request the following: Step 1. Rebase from the latest Roundcube branch master into your PR. Step 2. Re-test to make sure your new code still works as expected Step 3. Comment back here once it has been tested and will merge cleanly. Once this has been done we will treat it like a new Pull Request and consider it for acceptance. Apologies for the inconvenience. Thank you for contributing to Roundcube! |
|
Any progress with this? Since Roundcube uses Guzzle HTTP Client it would be nice to use it here too. |
No description provided.