Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a few problems with the dovecot_passwdfile password-driver.
$handle
and$newhash
- introduced in commitca523bd7facf29aaabf08718252314fca05c83a5
)password::hash_password
-function returns false (which could happen when usingdovecot
aspassword_algorithm
), the code would still proceed to change the password to an empty string even though hashing failed. It now raises an error instead.\{SSHA256\}...
Let me know if something needs to be changed.
Thanks for developing an awesome mail client!