Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

雑談会ログのissueの作成時刻を月曜日の10時に変更 #139

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

toyamarinyon
Copy link
Contributor

月曜日に作って、金曜日までにみんな書いていけば雑談置き場にもなるしpublicだしいいかなと思いました。

@shige
Copy link
Member

shige commented Nov 7, 2023

https://github.com/route06/development-meeting/pull/139/files#diff-3851e8162c8d77ec99b73a2cf88b9e5482071bd0fa55e60f6a2a870463997a4cL17
を修正しないと月曜の日付になりそう? @toyamarinyon

@hoshinotsuyoshi
Copy link
Contributor

なるほど...! 自分で書いたところですが忘れてました 😇
(手元はmacなのでdateコマンドが違うので良くわからなかったので docker でubuntuイメージを動かした )

-d '4 days' 足せばいいかも

$ docker run -it --rm ubuntu bash
Unable to find image 'ubuntu:latest' locally
latest: Pulling from library/ubuntu
bfbe77e41a78: Pull complete
Digest: sha256:2b7412e6465c3c7fc5bb21d3e6f1917c167358449fecac8176c6e496e5c1f05f
Status: Downloaded newer image for ubuntu:latest

root@7620eb2b2e7c:/# date '+%Y/%m/%d'
2023/11/07

root@7620eb2b2e7c:/# date '+%Y/%m/%d' -d '4 days'
2023/11/11

@toyamarinyon
Copy link
Contributor Author

レビューありがとうございます!修正します!!!

@toyamarinyon
Copy link
Contributor Author

レビューありがとうございました!マージして動かしてみてダメだったら調整します!

@toyamarinyon toyamarinyon merged commit c4568d1 into master Nov 7, 2023
@toyamarinyon toyamarinyon deleted the toyamarinyon-patch-1 branch November 7, 2023 01:59
@toyamarinyon
Copy link
Contributor Author

#140 11/11になったので、+3に変更した方がいい?実行した時間がよくなかったかな。

@@ -14,6 +14,6 @@ jobs:
run: |
latest=$(gh issue list --jq '.[].title' --json title --search "雑談会 sort:created-desc" --limit 10 | grep 回 | grep -oE '[0-9]+' | head -1)
latest=$(($latest+1))
gh issue create --title "第${latest}回 雑談会ログ - `date '+%Y/%m/%d'`" --body "今週の雑談会のログです:memo:"
gh issue create --title "第${latest}回 雑談会ログ - `date --date '+4 days' '+%Y/%m/%d'`" --body "今週の雑談会のログです:memo:"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commentが遅くなりましたが date --date 'next friday' +%Y/%m/%d にした方が、実行日時に依存しにくくなるかなと思いました。(TZは考慮してないですが)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next fridayできるんですね。後で修正Pull request作ります!

Copy link
Member

@masutaka masutaka Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next friday

$ brew install coreutils していれば、gdate コマンドが使え、$ man gdate でいろいろ確認できますね。:smile:

Copy link
Member

@masutaka masutaka Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`date --date '+4 days' '+%Y/%m/%d'`

あと、今回はそんなに関係ないですが、$(date --date '+4 days' '+%Y/%m/%d') にしたほうが、入れ子に出来る、可読性が上がるなどメリットがありそうです。常に $(...) を使うで良いと思います。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants