Skip to content

Conversation

@dinhkarate
Copy link
Contributor

@dinhkarate dinhkarate commented Jan 29, 2026

Summary

  • Add --vertex-import-prefix CLI flag to specify a prefix when importing Vertex service account credentials
  • Prefix is saved to the credential JSON file for model namespacing (e.g., imagen-fast/gemini-2.0-flash)
PR-CLI

Changes

  • cmd/server/main.go: Add --vertex-import-prefix flag and pass to DoVertexImport()
  • internal/cmd/vertex_import.go: Accept prefix parameter and set Prefix field in storage
    Usage

Import with prefix

./cli-proxy-api -vertex-import=service-account.json -vertex-import-prefix=imagen-fast

Models will appear as:

test/imagen-4.0-ultra-generate-001
imagen/imagen-4.0-generate-001
image

Testing

  • Build passes
  • Import with prefix works
  • Prefix saved correctly in credential file
  • Models display with prefix in /v1/models
  • Image generation works with prefixed model name

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dinhkarate, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Vertex AI integration by adding the capability to namespace models during the service account import process. Users can now define a custom prefix via a new CLI flag, which is then stored with the credentials and applied to Vertex model names, improving model management and clarity within the system.

Highlights

  • New CLI Flag for Vertex Import: Introduced a new CLI flag, --vertex-import-prefix, allowing users to specify a custom prefix when importing Vertex service account credentials.
  • Model Namespacing: The provided prefix is now saved within the Vertex credential JSON file, enabling model namespacing (e.g., imagen-fast/gemini-2.0-flash) for better organization and identification.
  • Credential Storage Update: The VertexCredentialStorage struct has been updated to include a Prefix field, ensuring the specified prefix is persisted alongside other credential details.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a --vertex-import-prefix flag to allow namespacing for Vertex models, which is a useful feature. The implementation is straightforward. I've left a few comments with suggestions for improvement, mainly around consistency with the existing codebase, clarifying comments, and ensuring all relevant data structures are populated with the new prefix. I also noted a minor issue in the .gitignore file.

.beads/
.opencode/
.cli-proxy-api/
.venv/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's a good practice for text files to end with a newline character. Some tools might not process the last line correctly if it's not terminated by a newline.

.venv/

// Type is the provider identifier stored alongside credentials. Always "vertex".
Type string `json:"type"`

// Prefix optionally namespaces models for this credential (e.g., "teamA/gemini-2.0-flash").
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The example in this comment is a bit confusing as it appears to show a full namespaced model name instead of just a prefix. To improve clarity, consider rephrasing it to show an example prefix and the resulting model name.

Suggested change
// Prefix optionally namespaces models for this credential (e.g., "teamA/gemini-2.0-flash").
// Prefix optionally namespaces models for this credential (e.g., "teamA"). This will result in model names like "teamA/gemini-2.0-flash".

@dinhkarate dinhkarate changed the title Feat(vertex)/add prefix field Feat(vertex): add prefix field Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant