-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(codex): remove unsupported 'user' field from /v1/responses payload #1523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove the 'user' field from the raw JSON as requested.
Add test to verify deletion of user field in response
Summary of ChangesHello @xxddff, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where requests to the Codex upstream via '/v1/responses' were failing due to an unsupported 'user' parameter. The change implements a filter to remove this field from the request payload, ensuring successful communication with the upstream API and improving the robustness of the proxy. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly addresses the issue of the unsupported user field in Codex API requests by removing it from the payload. The addition of a new test case ensures this change is properly verified. My review includes a couple of minor suggestions to improve comment clarity and test failure diagnostics, which will enhance the code's long-term maintainability. Overall, this is a good fix.
internal/translator/codex/openai/responses/codex_openai-responses_request.go
Outdated
Show resolved
Hide resolved
internal/translator/codex/openai/responses/codex_openai-responses_request_test.go
Outdated
Show resolved
Hide resolved
…equest.go Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ses_request_test.go Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
What does this PR do?
This PR filters out the
userfield from the raw JSON body when proxying requests to the Codex upstream via/v1/responses.Why is this change important?
Currently, when sending a request to the Codex upstream in the OpenAI
/v1/responsesformat , the upstream returns a400 Bad Requesterror because it does not support theuserparameter.