Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix route node listeners not being unregistered in routeNode HoC #245

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Fix route node listeners not being unregistered in routeNode HoC #245

merged 1 commit into from
Jan 26, 2018

Conversation

whs
Copy link
Contributor

@whs whs commented Jan 26, 2018

componentWillUnmount is missing an n

@troch
Copy link
Member

troch commented Jan 26, 2018

Good catch

@troch troch changed the title react-router5: Fixed typo in routeNote Fix route node listeners not being unregistered in routeNode HoC Jan 26, 2018
@troch troch added the bug label Jan 26, 2018
@troch troch merged commit 0198602 into router5:master Jan 26, 2018
@troch
Copy link
Member

troch commented Jan 26, 2018

Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whs @troch