Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script phase to correct ObjectiveGit linker references. #209

Closed
wants to merge 0 commits into from

Conversation

tiennou
Copy link

@tiennou tiennou commented Jul 3, 2013

Fixes #207

@rowanj
Copy link
Owner

rowanj commented Jul 4, 2013

The runtime link path should just be set in the project options; see 3b0af68

@tiennou
Copy link
Author

tiennou commented Jul 4, 2013

Nice ! It's been a while since I had to install_name_tool stuff around, so it's a welcome addition that web can now change a framework/library install path without having to muck with its Xcode project. Yay !

The other commit is just a really quick fix while you were off, but I'm pretty sure it leaks :-S.

@tiennou
Copy link
Author

tiennou commented Jul 4, 2013

Oh, and I think the appearance of #207 is related to a change in ObjectiveGit configurations, but I'm not sure (the weird @rpath/ObjectiveGit.framework/ObjectiveGit come from it).

@rowanj
Copy link
Owner

rowanj commented Jul 8, 2013

Should be fixed in 0.14.95; I cherry-picked the 10.7 fix from this branch, thanks very much.

@rowanj rowanj closed this Jul 8, 2013
ssp pushed a commit to ssp/gitx that referenced this pull request May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest autoupdate breaks gitx
2 participants