Patch/fix sidebar template icons #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here I am attaching preview of how it looked before and how it looks when applying changes above. Make sure you click on Before & Now and switch tabs to compare. BeforeNowNow (Retina) |
|
Looks great; I'm excited to merge this when I've got a few more of the 0.15 launch bugs sorted out. 👍 |
This removes need for own rendered highlighted sidebar icon.
This is replacement for icons by Alexis Hildebrandt. I tried to be close as possible to Alexis design, however there are following changes: (1) Icons are now PDF, no need for @2x version, less files (2) SVG source, instead Pixelmator which is proprietary paid software (3) Icons are pixel aligned to non-Retina pixel boundaries (look sharp) (4) Folder & remote (cloud) look are more inline with OSX default icons
Also removed old Acorn sources and Pixelmator sources. Icons were made to preserve style of previous ones. No need for source as icons are SVG.
|
Rebased to latest |
rowanj
added a commit
that referenced
this pull request
Jul 20, 2014
|
Thanks for the rebase; love it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSImageCellfor applying actual effect, which makes proper proper overlay effect depending on platform