Prevents selecting a header that already is selected. #13
Conversation
RafaelSeSouza
requested review from
canastro,
victorbotamedi,
renancaraujo,
bernardobelchior and
nfsxreloader
packages/swayze/lib/src/core/controller/selection/user_selections/model.dart
Show resolved
Hide resolved
RafaelSeSouza
force-pushed
the
fix/add-existing-header-selection
branch
from
1084b99 to
d6a66f1
Compare
@bernardobelchior Done. Bumped to |
packages/swayze/CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| # 1.2.0 | |||
|
|
|||
| - Removes `id` property from `UserSelectionModel`. | |||
There was a problem hiding this comment.
This is technically a breaking change, although I doubt there is someone using this id.
I think for the time being we should mark this as deprecated and remove it from the API in a future major version (i.e., 2.0.0). What do you think?
Another option would be to release 2.0.0 already, but I think that would be too hasty. Specially since we have other PRs that would probably make sense to bundle in a new version release
There was a problem hiding this comment.
I think you're right. Let me revert the changes and mark it as deprecated, and then we remove it on version 2.
| @@ -13,6 +15,7 @@ const _uuid = Uuid(); | |||
| /// Defines a [Selection] that is controllable by a [UserSelectionState]. | |||
| abstract class UserSelectionModel extends Selection { | |||
| /// Unique identifier of a selection in a [UserSelectionState] | |||
| @Deprecated('') | |||
There was a problem hiding this comment.
Can we add a message? E.g., "id is deprecated and not used. It will be removed in the next major version"
There was a problem hiding this comment.
I had a message like this, but leaving it blank already shows a similar default message.
RafaelSeSouza
force-pushed
the
fix/add-existing-header-selection
branch
from
a638ad5 to
1f23d78
Compare
Related to
N/A
Context
We should not add a header to a selection that already has that header selected.
Approach
UserSelectionState.addSelectionto prevent a selection to be added twice.UserSelectionModel, as same selections can have different ids. We could remove the entireUserSelectionModelabstract class, and useSelectiondirectly, but that would break the API.