improv: allow defining limits for elastic grid #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfsxreloader
requested review from
victorbotamedi,
bernardobelchior,
canastro,
RafaelSeSouza and
renancaraujo
RafaelSeSouza
approved these changes
Jun 7, 2022
packages/swayze/lib/src/core/controller/table/header_state.dart
Outdated
Show resolved
Hide resolved
packages/swayze/lib/src/core/controller/table/header_state.dart
Outdated
Show resolved
Hide resolved
packages/swayze/lib/src/core/controller/cells/cells_controller.dart
Outdated
Show resolved
Hide resolved
| final maxPosition = elasticCount != null | ||
| // in case the user has settled a max elastic count, we should | ||
| // limit the grid expansion to that count, however, if that limit | ||
| // is lower than the table size, we should prioritize the table size |
There was a problem hiding this comment.
if that limit is lower than the table size, we should prioritize the table size over it.
Shouldn't it always be lower than maxElasticCount? In which case does it make sense to have a table bigger than maxElasticCount?
There was a problem hiding this comment.
it's more of a safe check, there shouldn't be a use case for that
nfsxreloader
force-pushed
the
improv/allow-limiting-elastic-grid
branch
from
93939c6 to
b1158db
Compare
Maybe when we merge to Or when we add the |
That's fine by me, as long as we create an issue to track it 😄 |
bernardobelchior
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Allows defining the max amount of columns or rows that the elastic grid can have.
Approach
Allows to settle
maxElasticColumnsandmaxElasticRowsonSwayzeTableDataController.