Select & MultiSelect Chip Colors - ROWY-135 #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in app - last task; showing colors on chips
… implementing some logic
devsgnr
added
enhancement
|
@devsgnr is attempting to deploy a commit to the Rowy Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
For some reason; cc: @shamsmosowi |
shamsmosowi
reviewed
Mar 23, 2023
| setSelectedFields(fieldKeys) | ||
| fieldKeys.forEach(field => { | ||
| setSelectedFields(fieldKeys); | ||
| fieldKeys.forEach((field) => { |
There was a problem hiding this comment.
code formatter is making changes to files not relevant to the PR
shamsmosowi
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #514
🚣🏽 Worked on creating color selection menu for Select & MultiSelect chips (12 predefined colors created from the existing color palette and using
paletteToMuifunction to generate thelightanddarkvariants)🚣🏽 Worked on adding the
react-color-palettecomponent to be able to customize thelightanddarkvariant of any colors (predefined or can start fromaGray)🚣🏽 Worked on adding the
colorsobject to theconfigobject in the table's schema🚣🏽 Made color changes to everywhere that has a chip
Few things that I'm still working on
Working on deleting bothoptionsandcolorsvalues at the same time (blocker)RetainYes, No, Maybecoloring to live alongside the new coloring system (nice to have)