feat: stage支持质量红线的准入准出 TencentBlueKing#4732 增加准入质量红线控制逻辑

royalhuang · Aug 8, 2021 · 474584f · 474584f
1 parent 16cf5d7
commit 474584f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.../com/tencent/devops/process/engine/control/command/stage/impl/CheckPauseReviewStageCmd.kt b/.../com/tencent/devops/process/engine/control/command/stage/impl/CheckPauseReviewStageCmd.kt
@@ -84,7 +84,6 @@ class CheckPauseReviewStageCmd(
                 LOG.info("ENGINE|${event.buildId}|${event.source}|STAGE_QUALITY_CHECK_FAILED|${event.stageId}")
                 // TODO 暂时只处理准入，后续需要兼容准出
                 commandContext.stage.checkIn?.status = BuildStatus.QUALITY_CHECK_FAIL.name
-                commandContext.buildStatus = BuildStatus.QUALITY_CHECK_FAIL
                 commandContext.latestSummary = "s(${stage.stageId}) failed with QUALITY_CHECK_IN"
                 commandContext.cmdFlowState = CmdFlowState.FINALLY
                 return

diff --git a/...tencent/devops/process/engine/control/command/stage/impl/UpdateStateForStageCmdFinally.kt b/...tencent/devops/process/engine/control/command/stage/impl/UpdateStateForStageCmdFinally.kt
@@ -148,7 +148,8 @@ class UpdateStateForStageCmdFinally(
     private fun updateStageStatus(commandContext: StageContext) {
         val event = commandContext.event
         // 更新状态
-        pipelineStageService.updateStageStatus(buildId = event.buildId,
+        pipelineStageService.updateStageStatus(
+            buildId = event.buildId,
             stageId = event.stageId,
             buildStatus = commandContext.buildStatus,
             checkIn = commandContext.stage.checkIn,