Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 2 modules break #29

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Test 2 modules break #29

merged 2 commits into from
Jun 10, 2024

Conversation

rozaychen
Copy link
Owner

Issue #

Description

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

API Breakage Report

💔 Public API Breaking Change detected:

### Module: Amplify
Accessor Amplify.testBreak1.Get() has return type change from Swift.Float to Swift.Int
Accessor Amplify.testBreak1.Set() has parameter 0 type change from Swift.Float to Swift.Int
Var Amplify.testBreak1 has declared type change from Swift.Float to Swift.Int

@github-actions github-actions bot requested a review from RozayC June 10, 2024 23:21
@rozaychen rozaychen merged commit bd9680b into main Jun 10, 2024
@rozaychen rozaychen deleted the test-rozay-6 branch June 11, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant