Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test has API Folder #98

Open
wants to merge 156 commits into
base: main
Choose a base branch
from
Open

Test has API Folder #98

wants to merge 156 commits into from

Conversation

rozaychen
Copy link
Owner

Issue #

Description

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rozaychen
Create swift-api.yml
3695cd4
@rozaychen
Create apiBreakage.yml
fddd484
@rozaychen
Delete .github/workflows/name: SwiftAPIBreakage on: pull_request: typ…
ca82303 
…es: [opened, synchronize] jobs: buildAndCheckAPIBreakage: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 with: ref: master fetch-depth: 0 - uses: ltetzlaff directory

Delete extra folder
@rozaychen
Merge pull request #1 from rozaychen/rozaychen-patch-1
3d65ad1 
chore: removing extra folder
@rozaychen
Update apiBreakage.yml
69fef3f
@rozaychen
Update apiBreakage.yml
d8c2cf2
@rozaychen
Update apiBreakage.yml
06a517f
@rozaychen
Update Amplify.swift
79b6371
@rozaychen
Merge pull request #2 from rozaychen/rozaychen-patch-2
6fcb615 
chore: Test No API break
@rozaychen
chore: Test No API Break
b3c6d2d
@rozaychen
Merge pull request #4 from rozaychen/rozaychen-patch-4
6f702cd 
chore: Test No API Break
@rozaychen
Update Amplify.swift
9c64c95
@rozaychen
Delete .github/workflows directory
4baff0a
@rozaychen
Create apiBreak.yml
eb49b7f
@rozaychen
Add API file
083a839
@rozaychen
Merge pull request #5 from rozaychen/rozaychen-patch-4
ecd3536 
chore: Test API break
@rozaychen
Change to adaptation version of swift-api-diff
0a1edb5
@rozaychen
Update
1cb3b45
@rozaychen
Temporary change 5.9 to 5.1
3348251
@rozaychen
Update Package.swift
403cc88
@rozaychen
Update apiBreak.yml
dff148c
@rozaychen
Update apiBreak.yml
b98b0a4
@rozaychen
Update apiBreak.yml
035457a
@rozaychen
Create apiBreakTest.yml
b5f9c19
@rozaychen
Update apiBreakTest.yml
528b8a9
@rozaychen
Update apiBreakTest.yml
4148986
@rozaychen
Create check_deletions.yml
186008c
@rozaychen
Create check_deletions.sh
c7b5943
@rozaychen
Update check_deletions.sh
453a30f
@rozaychen
Update check_deletions.yml
cf6f55a
rozaychen and others added 27 commits June 13, 2024 10:04
@rozaychen
Update expected-result.txt
a0be698
@rozaychen
Update expected-result.txt
855b3f3
@rozaychen
Update expected-result.txt
cb0d13e
@rozaychen
Update test json
0929886
@rozaychen
Update expected-result.txt
54100d5
@rozaychen
Update B.json
fba1df4
@rozaychen
Update expected-result.txt
b75e0a0
@rozaychen
Update APIDigesterCheck.yml
64517d9
@rozaychen
Delete api-dump directory
8ce8338
@rozaychen
Update Amplify.swift
fe919ba
@rozaychen
Update apiBreakTest.yml
b3809ff
@rozaychen
Update apiBreakTest.yml
1ed1ee2
@rozaychen
Update apiBreakTest.yml
f9826de
@rozaychen
Update apiBreakTest.yml
e2650a8
@rozaychen
Update apiBreakTest.yml
5c2e20d
@rozaychen
Update apiBreakTest.yml
4a86e6f
@rozaychen
Update apiBreakTest.yml
99e84ef
@github-actions
Update API dumps for new version
54cf39f
@rozaychen
Merge pull request #95 from rozaychen/test-no-api-folder
0868707 
Update Amplify.swift
@rozaychen
Delete api-dump directory
cd20f4b
@rozaychen
Update apiBreakTest.yml
6952228
@rozaychen
test no api folder
95b7a86
@github-actions
Update API dumps for new version
90abd65
@github-actions
Update API dumps for new version
3ff74b5
@rozaychen
Merge pull request #96 from rozaychen/test-no-api-folder
9d58009 
test no api folder
@rozaychen
Test has API Folder
d5e110e
@github-actions
Update API dumps for new version
9bdde29
@github-actions GitHub Actions
Copy link

API Breakage Report

💔 Public API Breaking Change detected:

Module: Amplify
Accessor Amplify.testBreak1.Get() has return type change from Swift.Float to Swift.Int
Accessor Amplify.testBreak1.Set() has parameter 0 type change from Swift.Float to Swift.Int
Var Amplify.testBreak1 has declared type change from Swift.Float to Swift.Int

@github-actions github-actions bot requested a review from RozayC June 13, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RozayC RozayC Awaiting requested review from RozayC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rozaychen