Fix buggy sorting in dataexplorer_table.php #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Table sorting had errors : - Current Live version uses parseInt to sort values so don't sort numbers that have the same integer part - At least on today's (03/28) values, had some weird bug : when sorting by ascending weekly growth, mayotte's -60,5% and St-Pierre-et-Miquelon's -100,0% were somewhere in the middle and seemed to cause some reset in the sorting as further down the values seemed in the correct order. Same thing when changing the order around Moselle's +0,00. Didn't want to debug the custom sorting algorithm so I used javascript's Array.sort() function, works like a charm and even improved performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table sorting had errors :
Current Live version uses parseInt to sort values so don't sort numbers that have the same integer part
At least on today's (03/28) values, had some weird bug : when sorting by ascending weekly growth, Mayotte's -60,5% and St-Pierre-et-Miquelon's -100,0% were somewhere in the middle and seemed to cause some reset in the sorting as further down the values seemed in the correct order. Same thing when changing the order around Moselle's +0,00. Didn't want to debug the custom sorting algorithm so I used javascript's Array.sort() function. Works like a charm and even seems to improve performance.