-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additionalHeaders and rejectUnauthorized are not respected by the extension #37
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
Comments
rozpuszczalny
added
bug
Something isn't working
help wanted
Extra attention is needed
good first issue
Good for newcomers
labels
May 19, 2021
any news about this issue? :-) |
@saiballo I was hoping that some newcomer will pick the issue and solve it ;) Anyway, since no one is interested in it, I'll fix it soon then |
thank you very much!!! |
rozpuszczalny
added a commit
that referenced
this issue
Oct 13, 2021
…s-from-config #37 | Respect rejectUnauthorized and additionalHeaders in http(s) options
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
Both
additionalHeaders
andrejectUnauthorized
options are not respected by the extension.Steps to reproduce:
redmine.additionalHeaders
to{"Authorization": "Anything"}
redmine.url
to any webserver address, which can intercept headers (e.g. Burp Suite)Redmine: List open issues assigned to me
Expected results
Request headers should include
Authorization: Anything
.Actual results
No header
Authorization
is found in the request headers.Note for new-commers
Creating new instance of
RedmineServer
does not includeadditionalHeaders
andrejectUnauthorized
from configuration. One needs to additionally parse and pass these options into the new instances. These are created insrc/extension.ts
,src/trees/my-issues-tree.ts
andsrc/trees/projects-tree.ts
:vscode-redmine/src/trees/projects-tree.ts
Lines 11 to 18 in cbf738d
vscode-redmine/src/trees/my-issues-tree.ts
Lines 9 to 15 in cbf738d
vscode-redmine/src/extension.ts
Lines 57 to 64 in cbf738d
Thanks to @saiballo for spotting that!
The text was updated successfully, but these errors were encountered: