Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DMA IRQ issue for bidirectional DMA transfer #580

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

jlpettersson
Copy link
Contributor

By reading the code, this seems to be a bug, caused by a typo. The function check_irq0() seems to be intended to check irq0 for both channels. But for channel 1, it is set to check irq1.

The corresponding function check_irq1() does check irq1 for both channels.

By reading the code, this seems to be a bug, caused by a typo.
The function `check_irq0()` seems to be intended to check `irq0` for
both channels. But for channel 1, it is set to check `irq1`.
Copy link
Member

@jannic jannic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch. This could have caused hours of debugging!
@9names, you know this code better than me, I'd prefer if you acked the fix as well before merging.

Copy link
Member

@9names 9names left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me

@jannic jannic merged commit 9b7acef into rp-rs:main Apr 6, 2023
@jlpettersson jlpettersson deleted the fix_dma_irq_fn branch April 6, 2023 11:27
@9names 9names mentioned this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants