Mark ReadTarget and WriteTarget as unsafe #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clippy is, of course, absolutely right: There should be some docs explaining the safety requirements. |
jannic
force-pushed
the
unsafe-dma-targets
branch
from
19ccd24 to
4976e93
Compare
jannic
added
breaking change
Merged
jannic
added a commit
to jannic/rp-hal
that referenced
this pull request
Aug 30, 2023
Those trait impls were introduced after rp-rs#621 was opened and were therefore not covered by that PR.
jannic
added a commit
that referenced
this pull request
Aug 30, 2023
Fix build errors introduced by #621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the "mark traits as unsafe" part of #620 (comment)