-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved configuration #9
base: master
Are you sure you want to change the base?
Conversation
and supports for TOML configuration file.
…taframe from lyse. This is a repeat of a commit from zakv that Russ has never approved.
…e and disable variables. I think what I really want to do is define a "group" label to make it easy to optimize some collection of variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple minor suggestions, but overall looks good to me!
Full disclosure though I don't think I have merge permissions on this repo, so we'd need Russ to merge it if he's ok with it
So it actually looks like I might have merge permissions on this repo, but I'll give Russ a chance to weigh in regardless. @rpanderson would you mind if we merged this? And are you interested in taking a look at Ian's other upcoming PRs before we merge them? |
This includes a pretty significant change to the configuration file format, enabling grouping of parameters as well as enabling and disabling of specific parameters. The goal is to make it easy to turn on and off different options during optimization rather than keeping around a pile of similar config files.
A configuration might look like:
At zakv's advice I am keeping this pull request brief, but there are several more pieces of functionality upcoming:
analysislib_mloop
tools rather than just cloning a repo (this makes distinguishing changes associated with your optimization tasks versus changes to the code base tricky). After this the lyse script will look like (this is done and a pull request will follow once this one is merged):