Little cleanup #79
Open
Little cleanup #79
+96
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gw0
force-pushed
the
gw0/little-cleanup
branch
from
d06ce90 to
b366362
Compare
rpardini
added
the
outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #78 and cleans up a few things.
It contains one non-backward compatible change. It affects only those who override
REGISTRIESenv var, use DockerHub, but do not explicitly setREGISTRIES="auth.docker.io registry-1.docker.io". As part of the organization all default configurations were put inDockerfile(including previously internally hard-coded values, such as DockerHub servers). This change is necessary to cover the use cases where one does not want to cache DockerHub, but wants to cache another registry. If one does not set theREGISTRIESenv var (and the default inDockerfileis used), everything works as it used to (it works even for GitLab.com).