Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve portability and fix compilation on CLISP #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bohonghuang
Copy link

On some implementations that support gray streams, such as CLISP, input-stream-p and output-stream-p are not generic functions, which makes the following code not compiled:

(defmethod input-stream-p ((stream fast-input-stream))
  (with-slots (buffer) stream
    (and (typep buffer 'input-buffer))))

(defmethod output-stream-p ((stream fast-output-stream))
  (with-slots (buffer) stream
    (and (typep buffer 'output-buffer))))

Indeed, input-stream-p and output-stream-p return t for any instance of fundamental-input-stream and fundamental-output-stream, so the above 2 methods are not required by other implementations where they are generic functions though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant