-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update methods to be compatible with React.StrictMode #151
Conversation
Thanks for the answer @rpearce. |
@jpreynat No, and I don't suspect it will be released for a while. Given this, I'll review this PR fully before end of next week. I'm currently out of office officially until the 17th, as my wife and I are moving continents, but I'll make some time for this. |
Thanks for the quick update @rpearce. Let me know if you have any feedback on the PR. |
@jpreynat I'm back and settled in the USA and back at work. This will happen ASAP (I'll review tonight or tomorrow) |
Great, thanks for the update! |
Code looking good! Need to go through all the storybook and build stuff and make sure |
If all is well when I test tomorrow, then I'll ship tomorrow |
Looks good, my friend! There are going to be massssssssssive changes coming down the pipeline to redo basically everything in the coming months. For now, I will:
Thank you for your patience and contribution. If you have any other desires for this library, please create an Issue, and I'll consider it for the rewrite! |
@jpreynat this has been published as |
Thanks @rpearce for the fast release. |
This pull request doesn't fix (the following issue) #143 but addresses the removal of now deprecated methods in React 16 to be compatible with
<React.StrictMode>
.Since it now uses the
getDerivedStateFromProps
lifecycle method in its actual state, I set the minimum required version ofreact
andreact-dom
to^16.4.0
which includes the bugfix for this method.I don't have time to improve it better (switching to hooks, etc...) right now, but would be happy to do so when I can find some spare time later.
Pre-Flight Checklist
I have made sure to
X-0-stable
branchadd a Storybook example (if necessary)$ yarn run storybook
$ yarn run build
to build the project code & static exampledocs/index.html
works:$ yarn run start