Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin dependencies #122

Closed
IanVS opened this issue Oct 2, 2017 · 4 comments
Closed

Unpin dependencies #122

IanVS opened this issue Oct 2, 2017 · 4 comments

Comments

@IanVS
Copy link

IanVS commented Oct 2, 2017

Because this project uses pinned dependency versions, it's very likely that consumers will end up with multiple versions of various dependencies like React. React doesn't like to have multiple versions, and in some cases this is causing me problems.

I think it would be better to use semver and specify only the minimum required versions, and allow proper dependency resolution. You can check in a package.lock or yarn.lock file to ensure that consistent versions are used during development, if you like. But I don't think it's a good idea to pin dependencies as you have in your package.json.

@turadg
Copy link

turadg commented Oct 16, 2018

@rpl what is your opinion on this request? Solving is as easy as merging #169

@kangax
Copy link

kangax commented Aug 13, 2019

would love to see #169 merged; getting warnings about outdated react version in our project

@rpl
Copy link
Owner

rpl commented Sep 18, 2020

On master all the dependencies are now unpinned (changes introduced in #197), I'm going to release it soon as a new major release.
I'll keep this issue open until the new version has been released on npm.

@rpl
Copy link
Owner

rpl commented Sep 21, 2020

Released on npm as part of v0.8.0

@rpl rpl closed this as completed Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants