Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust in semver #169

Closed
wants to merge 1 commit into from
Closed

Trust in semver #169

wants to merge 1 commit into from

Conversation

turadg
Copy link

@turadg turadg commented Sep 10, 2018

Will reduce duplication in node_modules when it already has newer versions of these dependencies.

Fixes #122

#164 does the same for react deps

Will reduce duplication in `node_modules` when it already has newer versions of these dependencies.
@turadg turadg mentioned this pull request Oct 16, 2018
@vbuch
Copy link

vbuch commented Dec 13, 2018

This should go in. Currently npm reports what I've included below. Issues like that could get resolved by this PR.

Moderate        Regular Expression Denial of Service
Package         underscore.string
Patched in      >=3.3.5
Dependency of   flow-coverage-report [dev]
Path            flow-coverage-report > badge-up > svgo > js-yaml > argparse
                  > underscore.string
More info       https://nodesecurity.io/advisories/745

found 1 moderate severity vulnerability in 22218 scanned packages
  1 vulnerability requires manual review. See the full report for details.

Well, not sure if the PR will fix this specific one, but similar issues...

@turadg
Copy link
Author

turadg commented May 20, 2019

I'm closing this PR because I don't think it will be merged and I'd like it out of my /pulls list. At Quizlet we've switched from Flow to TypeScript.

@turadg turadg closed this May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin dependencies
2 participants