[spec] Add Recommends %{_bindir}/sqlite3 for bash-completion for Fedora

[grumpey]

#1817 added the ability to utilize sqlite cache when available.
https://discussion.fedoraproject.org/t/why-bash-auto-completion-is-so-slow-with-dnf/88944 and
https://discussion.fedoraproject.org/t/dnf-autocompletion-is-too-slow/64038 Are users noting that bash completion is slow without sqlite installed.

= changelog =
msg: [spec] Add Recommends %{_bindir}/sqlite3 for bash-completion for Fedora
type: enhancement
related: #1817
related: https://discussion.fedoraproject.org/t/why-bash-auto-completion-is-so-slow-with-dnf/88944
related: https://discussion.fedoraproject.org/t/dnf-autocompletion-is-too-slow/64038

[j-mracek]

I checked the internal implementation and I think we don't need the recommend:

See:

    if ! _dnf_is_path "$cur"; then
        if [ -r "$__dnf_cache_file" ] && [ -x /usr/bin/sqlite3 ]; then
            case "$cmd$*" in
            listinstalled|listupdates|\
            dg|downgrade|\
            ri|rei|reinstall|\
            rm|remove*|erase*|\
            um|u-m|upgrade|upgrade-n*|\
            up|up-min|update|update-n*)
                COMPREPLY+=( $(_dnf_query_db installed "$cur") )
                ;;
            *)
                COMPREPLY+=( $(_dnf_query_db available "$cur") )
                ;;
            esac
        else
            COMPREPLY+=( $(compgen -W "$( _dnf_commands_helper $cmd "$@" "$cur" )") )
        fi
    fi

If I am not mistaken if sqlite3 is not present it uses an alternative approach. May I ask you for additional reasons why we should add the recommend?

[grumpey]

If I am not mistaken if sqlite3 is not present it uses an alternative approach. May I ask you for additional reasons why we should add the recommend?

The complaint here centers around the speed of the completion.
In some instances folks have reported a noticeable delay between 1-4 seconds when waiting for the tab completion or failures to complete.

I suspect some of this has to do with the cache being expired, but this could be mitigated somewhat by having a better internet connection. I do think this was worse back when I was utilizing cellular for internet.

When the cache is up to date, completion still appears to be a slower (.5 - 1 second) without sqlite on my machine. (AMD Ryzen 5 5600G )

Thanks

[j-mracek]

Ok, good point.

[j-mracek]

I am proposing to add additional condition (%{_bindir}/sqlite3 if (bash-completion and python3-dnf-plugins-core)).
If python3-dnf-plugins-core is not installed then the database cannot be updated and bash completion provides outdated results.

Be honest this approach is not perfect, because it uses resources during RPM transaction. DNF5 uses an alternative approach without external database.

[j-mracek]

I am really sorry but operator && is not supported. See https://rpm-software-management.github.io/rpm/manual/boolean_dependencies.html. May I ask you to replace && by and?

[grumpey]

Sorry about that, will fix later today.