More frendly dnf

[QuantumLoopHole]

I made a very slight change to DNF that I think would be fun to implement. It is a smiley face after the complete message.

I don't know how to do this, but it would be interesting if there was a way to customize a message like this on the user's end. Will look into it.

:)

[ppisar]

While I understand the sentiment, I don't think our enterprise customers would welcome it.

That means I'm against accepting this patch as it is now. A configurable implementation, as you suggested, would not suffer from this problem, and would be, in my opinion, acceptable.

I recommend making the whole "Complete!" message configurable with a default to the current "Complete!". The reason is an internationalization of the message because we cannot assume what way specific languages glue words and sentences together."

[ferdnyc]

While I understand the sentiment, I don't think our enterprise customers would welcome it.

That means I'm against accepting this patch as it is now. A configurable implementation, as you suggested, would not suffer from this problem, and would be, in my opinion, acceptable.

I recommend making the whole "Complete!" message configurable with a default to the current "Complete!". The reason is an internationalization of the message because we cannot assume what way specific languages glue words and sentences together."

In addition to all of this (which is very much YES), if you're going to decorate terminal messages, might as well just take a page from homebrew and use real emoji. #KidsToday won't even know what :) means! 😉

[jackiesogi]

I was searching for some repositories in order to start my open source contribution journey today, and then I saw this cute PR : )

[QuantumLoopHole]

I moved over to Arch, but I am booting up a fedora server, so I have a reason to actually build this. If anyone has any suggestions, please send them this way :)