Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: Check if the plugin instantiation was successful #2043

Merged

Conversation

jrohel
Copy link
Contributor

@jrohel jrohel commented Feb 7, 2025

Closes: #2042

Fixes crash if plugin instantiation fails and returns a null pointer.

Throws an exception even if `dlerror` did not return an error message.
`libdnf_plugin_new_instance` and `dnf5_plugin_new_instance` may return
`nullptr`. This situation has not been addressed.
An exception is now thrown.
Copy link
Contributor

@kontura kontura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kontura kontura added this pull request to the merge queue Feb 10, 2025
Merged via the queue into rpm-software-management:main with commit 853cbfc Feb 10, 2025
15 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PluginLibrary::PluginLibrary: Unhandled null pointer on plugin instantiation
2 participants