-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DnfContext: add dnf_context_module_install() #1200
DnfContext: add dnf_context_module_install() #1200
Conversation
Straight mapping to `modulemd_profile_is_default()`.
This is useful if the profile is unspecified by the user. Match the dnf semantic of auto-defaulting to the only profile there is.
e2ce1ad
to
00e7f9e
Compare
Still learning the modular parts of the codebase and my C++ is a bit rusty, so let me know if there are better ways to do some things or bits I'm missing! |
@jlebon You'll also want your last commit to include changelog information, per the contribution doc: https://github.com/rpm-software-management/libdnf#contribution |
This is a C-compatible API similar to `dnf_context_module_enable()` which additionally marks the target packages for installation. This is similar to `dnf module install`. We intend to use this in rpm-ostree as well. Closes: rpm-software-management#874 = changelog = msg: Add new dnf_context_module_install() C API type: enhancement resolves: rpm-software-management#874
00e7f9e
to
88f58a2
Compare
Updated! ⬆️ |
@jlebon I am sorry but it looks like that the code will not work like expected (like dnf) when module stream requested to install is not enabled. @Conan-Kudo May I ask you for a ping when modularity PR appears? |
Yep, certainly. |
Thanks for the feedback. Can you expand on the differences between the two? From my understanding, doing |
This is a C-compatible API similar to
dnf_context_module_enable()
which additionally marks the target packages for installation. This is
similar to
dnf module install
.We intend to use this in rpm-ostree as well.
Closes: #874