Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotools #37

Merged
merged 3 commits into from
Sep 2, 2020
Merged

Autotools #37

merged 3 commits into from
Sep 2, 2020

Conversation

cgzones
Copy link
Contributor

@cgzones cgzones commented Aug 6, 2020

  • configure: replace deprecated macros

    • use LT_INIT instead of deprecated AC_PROG_LIBTOOL
    • use AS_HELP_STRING instead of deprecated AC_HELP_STRING
    • quote macros
  • autogen: use force option and enable warnings
    --force considers all files obsolete

  • ci: use in-tree autoconf wrapper

cgzones added 3 commits August 6, 2020 15:46
* use LT_INIT instead of deprecated AC_PROG_LIBTOOL
* use AS_HELP_STRING instead of deprecated AC_HELP_STRING
* quote macros
--force considers all files obsolete
@pmatilai
Copy link
Member

pmatilai commented Sep 2, 2020

Quoting macros should really be a separate commit from replacing deprecated macros, but I'll let it pass this once because the change is small enough to be visually verifiable.

Thanks for the patches!

@pmatilai pmatilai merged commit 20420bb into rpm-software-management:master Sep 2, 2020
@pmatilai
Copy link
Member

pmatilai commented Sep 2, 2020

Oh, I guess the macro quotation + deprecated macros is a result of running autoupdate? That'd explain/kinda excuse the single commit for them... (always good to mention such things even if it has no consequence on the end result)

@cgzones cgzones deleted the autotools branch September 2, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants