Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make -C the default for BuildOption(prep) #2998

Closed
hroncok opened this issue Mar 26, 2024 · 5 comments · Fixed by #3002
Closed

Make -C the default for BuildOption(prep) #2998

hroncok opened this issue Mar 26, 2024 · 5 comments · Fixed by #3002
Assignees
@pmatilai
Labels
handsfree Packaging automation and convenience packaging Package building, SPEC files, etc. RFE

Comments

@hroncok
Copy link
Contributor

hroncok commented Mar 26, 2024

See #2997 (comment)

It would make sense to make -C the default option for BuildOption(prep), so packages utilizing the Declarative builds feature don't have to pass custom -n to it. (Using custom -n is also used as an example in the documentation for BuildOption(prep), so that will need a different example.)
@pmatilai pmatilai added RFE handsfree Packaging automation and convenience packaging Package building, SPEC files, etc. labels Mar 27, 2024
@pmatilai pmatilai added this to RPM Mar 27, 2024
@pmatilai pmatilai moved this from Backlog to Priority in RPM Mar 27, 2024
@github-project-automation github-project-automation bot moved this to Backlog in RPM Mar 27, 2024
@pmatilai
Copy link
Member

Oh yup, thanks for filing this! The auto directory patch landed just after the buildsystem work so it kinda went under the radar, but it should complement the buildsystem work very nicely indeed.

pmatilai added a commit to pmatilai/rpm that referenced this issue Mar 27, 2024
@pmatilai
Default to automatic build directory path on declarative builds
3f221f8 
The new %(auto)setup -C option complements the declarative buildsystem
very nicely: this is a trivial detail, don't bother the packager. While
we can't default to it everywhere, Buildsystem is a great opportunity
to do so.

Suggested-by: Miro Hrončok <miro@hroncok.cz>

Fixes: rpm-software-management#2998
@pmatilai pmatilai mentioned this issue Mar 27, 2024
Merged
@pmatilai pmatilai moved this from Priority to In Review in RPM Mar 28, 2024
@pmatilai pmatilai self-assigned this Mar 28, 2024
pmatilai added a commit that referenced this issue Apr 3, 2024
@pmatilai
Default to automatic build directory path on declarative builds
9df9d9e 
The new %(auto)setup -C option complements the declarative buildsystem
very nicely: this is a trivial detail, don't bother the packager. While
we can't default to it everywhere, Buildsystem is a great opportunity
to do so.

Suggested-by: Miro Hrončok <miro@hroncok.cz>

Fixes: #2998
@github-project-automation github-project-automation bot moved this from In Review to Done in RPM Apr 3, 2024
@hroncok
Copy link
Contributor Author

hroncok commented Apr 3, 2024

Thanks.

I noticed the BuildOption(prep) documentation was not updated in that PR.

@pmatilai
Copy link
Member

pmatilai commented Apr 3, 2024

Oh, thanks for pointing that out! I didn't even remember we have that in the documentation (although it was written by me, so ... age doesn't come alone as they say around here)

@pmatilai
Copy link
Member

pmatilai commented Apr 3, 2024

Doubly more embarrassing as you mentioned that in the ticket description 😆
Will fix.

pmatilai added a commit that referenced this issue Apr 3, 2024
@pmatilai
Update Buildsystem(prep) docs as per the even more automatic -C default
5d4a476 
Should've been in commit 9df9d9e

Suggested-by: Miro Hrončok <miro@hroncok.cz>

Related: #2998
@pmatilai
Copy link
Member

pmatilai commented Apr 3, 2024

Maybe not the greatest example but at least something: 5d4a476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmatilai pmatilai

Labels
handsfree Packaging automation and convenience packaging Package building, SPEC files, etc. RFE
Projects
RPM
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Default to automatic build directory path on declarative builds pmatilai/rpm
2 participants
@hroncok @pmatilai