Bunch of sysusers.d handling fixes #2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lua has error() but no warning() (obviously) which we'll want in the next step, so for consistency lets just use macro.error() instead.
I'm quite sure I didn't really intend to test duplicate files behavior here...
People will want to use existing sysusers.d files through rpm and while we don't support 'r' and 'm' at this time, we shouldn't really call them "invalid" and error out. Issue a warning instead, and ignore. This is the first half of https://bugzilla.redhat.com/show_bug.cgi?id=2246236
sysusers.d(8) format permits empty lines and commits, and so must we. Add some extra fluff to the test-case for this. This is the second half of https://bugzilla.redhat.com/show_bug.cgi?id=2246236 Fixes: rpm-software-management#2741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially reported at https://bugzilla.redhat.com/show_bug.cgi?id=2246236 and also #2741. Details in the commit messages. Amazing how many bugs and oversights one can pack into such a tiny little macro 😆