Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zypper-plugins: match the new shebang (bsc#1212476) #1145

Conversation

wfrisch
Copy link

@wfrisch wfrisch commented Nov 30, 2023

see also:

This new patch dynamically patches the shebang. In this case /usr/bin/python3 gets changed to /usr/bin/python3.11.

Verified

This commit was signed with the committer’s verified signature.
renovate-bot Mend Renovate
see also:
- https://bugzilla.suse.com/show_bug.cgi?id=1212476
- https://build.opensuse.org/request/show/1129913

This new patch dynamically patches the shebang. in this case
/usr/bin/python3 gets changed to /usr/bin/python3.11.
@wfrisch
Copy link
Author

wfrisch commented Nov 30, 2023

It's a bit annoying because the permissions.py script gets updated at build time, which we have to take into account when calculating the hash. To verify the hash:

  • change python3 to python3.11
  • rpmlint/tools/get_whitelisting_digest.py --filter shell permissions.py
    40ace802b2077815f693c9abfbcef21cd6fa3f316e892f9461f0d22b04135c53

@wfrisch
Copy link
Author

wfrisch commented Nov 30, 2023

@FilippoBonazziSUSE
Copy link

Yeah, let's not do this (as per discussion). Let's rather address this in the digester

@danigm danigm added the opensuse label Dec 4, 2023
@wfrisch
Copy link
Author

wfrisch commented Dec 4, 2023

We decided to adapt the shell filter in rpmlint instead, so that it filters out the Python version in the shebang before hashing. The hashes will then stay the same and no further action will be necessary.

@wfrisch wfrisch closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants