Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbus-services: power-profiles-daemon (bsc#1219956) #1197

Conversation

wfrisch
Copy link

@wfrisch wfrisch commented Feb 19, 2024

The service was renamed from net.hadess.PowerProfiles, however the old service is being kept to ensure backwards compatibility for a while.
https://bugzilla.suse.com/show_bug.cgi?id=1219956#c2

The service was renamed from `net.hadess.PowerProfiles`, however the old
service is being kept to ensure backwards compatibility for a while.
@wfrisch
Copy link
Author

wfrisch commented Feb 19, 2024

Known unrelated CI failures:

rpm-build:opensuse-tumbleweed-aarch64 — RPMs failed to be built.
rpm-build:opensuse-tumbleweed-x86_64 — RPMs failed to be built.

#981 (comment)

@wfrisch wfrisch requested a review from mgerstner February 19, 2024 08:55
@wfrisch
Copy link
Author

wfrisch commented Feb 19, 2024

Note that upstream ships both the old and new D-Bus service, but only the new Polkit configuration.
Two options:
a) Don't change the upstream release. Keep the service whitelisted. Polkit will deny access to unconfigured actions.
b) Ask the maintainer to remove the old D-Bus service.
I vote a)

@Conan-Kudo
Copy link
Member

Or we could do c) ask the maintainer to add polkit configuration for both

@wfrisch
Copy link
Author

wfrisch commented Feb 19, 2024

True, but if we change the package I would prefer to remove the old service instead in order to keep things minimal.

@mgerstner
Copy link
Contributor

Hmm, this is strange, is the old service supposed to work with the new Polkit configuration?

@wfrisch
Copy link
Author

wfrisch commented Feb 19, 2024

Hmm, this is strange, is the old service supposed to work with the new Polkit configuration?

The package is working perfectly fine without the old service. I just asked the maintainer to remove it from the RPM.

The maintainer has since removed the old D-Bus service, so we can drop the
whitelisting for it as well:
https://build.opensuse.org/request/show/1148703
@wfrisch
Copy link
Author

wfrisch commented Mar 25, 2024

Updated PR without the old D-Bus services, that have since been dropped in the RPM:
https://build.opensuse.org/request/show/1148703

@mgerstner mgerstner merged commit 982d664 into rpm-software-management:opensuse Mar 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants