Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submodule_aware_builder (SAB) does not package submodules recursively #456

Closed
arcivanov opened this issue Apr 28, 2023 · 0 comments · Fixed by #457
Closed

Submodule_aware_builder (SAB) does not package submodules recursively #456

arcivanov opened this issue Apr 28, 2023 · 0 comments · Fixed by #457

Comments

@arcivanov
Copy link
Contributor

Submodules in the SAB can contain other submodules.
However, the current implementation of SAB ignores these recursive submodules breaking the source package as a result.

Solution is to recursively incorporate the submodules within the submodules into the final source package.
arcivanov added a commit to arcivanov/tito that referenced this issue Apr 28, 2023
@arcivanov
Submodules may contain other submodules. Do process and add those
6531219 
to the source tar.

fixes rpm-software-management#456
@arcivanov arcivanov mentioned this issue Apr 28, 2023
Merged
arcivanov added a commit to arcivanov/tito that referenced this issue Apr 28, 2023
@arcivanov
Submodules may contain other submodules. Do process and add those
f9f72fb 
to the source tar.

fixes rpm-software-management#456
arcivanov added a commit to arcivanov/tito that referenced this issue Apr 28, 2023
@arcivanov
Submodules may contain other submodules. Do process and add those
5b21da9 
to the source tar.

fixes rpm-software-management#456
arcivanov added a commit to arcivanov/tito that referenced this issue May 1, 2023
@arcivanov
Submodules may contain other submodules. Do process and add those
a3d9b72 
to the source tar.

fixes rpm-software-management#456
arcivanov added a commit to arcivanov/tito that referenced this issue May 1, 2023
@arcivanov
Submodules may contain other submodules. Do process and add those
f9efca7 
to the source tar.

fixes rpm-software-management#456
arcivanov added a commit to arcivanov/tito that referenced this issue May 1, 2023
@arcivanov
Submodules may contain other submodules. Do process and add those
53803cb 
to the source tar.

fixes rpm-software-management#456
FrostyX pushed a commit that referenced this issue May 16, 2023
@arcivanov @FrostyX
Submodules may contain other submodules. Do process and add those
835309b 
to the source tar.

fixes #456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Submodules may contain other submodules. Do process and add those to the source tar. arcivanov/tito
1 participant
@arcivanov