-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development v2.3 - Memory Management, Active Feature Publishing, Small Fixes #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…open_vins into charmoniumQ-fix-with-unique-ptr
…iangulation along with option to disable refinement, update triangulation docs to reflect this change
…th image (e.g. you can track many features and get a denser pointcloud, and specify that the filter only uses a few)
…efine FAST feature corner extractions
…more arbitary camera setups (still only a single toff though), queue to now process camera as soon as we have enough imu (reduced latency), retriangulation now uses seperate database with *all* possible measurements it can use
…determined automatically), so we can just use this config with open_vins. Only change will be to remove develop_v2.3 from .github/workflows/build_catkin.yml on push branches:[ master, develop_v2.3 ]
…lot faster compile
Opencv fixing
…perly sort features based on length, launch file tweaks
This was referenced Dec 1, 2020
Closed
goldbattle
changed the title
Development v2.3
Development v2.3 - Memory Management, Active Feature Publishing, Small Fixes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes
Validation
I ran a few runs on the ETH eurocmav dataset to compare performance vs previous releases. While there is no guarantee, I believe we don't have any major regressions in accuracy. Default levels of computational cost have gone up due to tracking of more points to have denser pointclouds. This can be tuned as necessary for any specific platform.
Vicon2gt Utility
We have also released a package to facilitate the generation of groundtruth trajectories.
Please check it out here: https://github.com/rpng/vicon2gt