Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails 6.1 related deprecation warnings #541

Merged
merged 3 commits into from
Dec 13, 2019

Conversation

dsantosmerino
Copy link
Contributor

@dsantosmerino dsantosmerino commented Dec 11, 2019

Blocked by rpush/modis#27

We are upgrading to Rails 6 our main application and we have noticed some deprecation warnings coming from Rpush code. With this PR those deprecation warnings should be fixed.

  • #update_attributes - It was just an alias of #update, now deprecated.
  • case_sensitive: true - Uniqueness validator will no longer enforce case sensitive comparisons.

@aried3r
Copy link
Member

aried3r commented Dec 13, 2019

Thank you for the contribution!

@aried3r aried3r merged commit 9e56e77 into rpush:master Dec 13, 2019
Adrian1707 pushed a commit to Adrian1707/rpush that referenced this pull request Apr 24, 2024
…arnings

Fix Rails 6.1 related deprecation warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants