Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would recommend not using
poetry
, particularly since using any other PEP517 compliant build backend makes things so much easier.I have kept the
dev
dependency as-is so you can simply runpip install .[dev]
, but I would recommend against using that because the only dependency there ispre-commit
, which is better if you have it installed and managed globally instead of within the venv. Otherwise the other dependencies are split like that becausetest
dependencies are often required by packagers, anddocs
can be used for the specific documentation build backend.I would also recommend to drop Python<3.8, and even python 3.8 at this point.